Skip to content

Fix plot tag rendering at horizontal positions #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sims1253 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

Fix plot tag rendering at horizontal positions #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/plot-render.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ table_add_tag <- function(table, label, theme) {
if (location %in% c("plot", "panel")) {
if (!is.numeric(position)) {
hjust <- try_prop(element, "hjust", default = 0.5)
vjust <- try_prop(element, "vjust", default = 0.5)
if (right || left) {
x <- (1 - hjust) * width
if (right) {
Expand All @@ -288,7 +289,6 @@ table_add_tag <- function(table, label, theme) {
x <- unit(hjust, "npc")
}
if (top || bottom) {
vjust <- try_prop(element, "vjust", default = 0.5)
y <- (1 - vjust) * height
if (top) {
y <- unit(1, "npc") - y
Expand Down
17 changes: 17 additions & 0 deletions tests/testthat/test-labels.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,23 @@ test_that("plot.tag.position rejects invalid input", {

})

test_that("left and right plot tags can be rendered inside plot regions", {
p <- ggplot(mtcars, aes(mpg, disp)) + geom_point() + labs(tag = "Fig. A)")

for (position in c("left", "right")) {
for (location in c("plot", "panel")) {
expect_no_error(
ggplotGrob(
p + theme(
plot.tag.position = position,
plot.tag.location = location
)
)
)
}
}
})

test_that("position axis label hierarchy works as intended", {
df <- data_frame(foo = c(1e1, 1e5), bar = c(0, 100))

Expand Down
Loading