feat: add a logging interface, dependency injectable loggers#233
Merged
feat: add a logging interface, dependency injectable loggers#233
Conversation
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 26.10% 26.10%
=======================================
Files 100 100
Lines 9218 9218
Branches 2215 2215
=======================================
Hits 2406 2406
Misses 6423 6423
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
5 tasks
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This PR adds an abstract
nebula::drivers::loggers::Loggerinterface that provides the following functions:debug(msg)info(msg)warn(msg)error(msg)child(name) -> std::shared_ptr<Logger>which creates a child logger (names are concatenated with.)A
NEBULA_LOG_STREAM(log_func, stream_args)macro is also provided for convenience.There are currently two implementations of this interface:
nebula::drivers::loggers::ConsoleLogger(innebula_common)nebula::drivers::loggers::RclcppLogger(innebula_ros)The motivation of this PR is to, in the long run, remove the dependency on RCLCPP from all Nebula packages except
nebula_ros.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks