Skip to content

feat: add IMU decoding support to OT128#362

Draft
mojomex wants to merge 2 commits intotier4:mainfrom
mojomex:feat/ot128-imu
Draft

feat: add IMU decoding support to OT128#362
mojomex wants to merge 2 commits intotier4:mainfrom
mojomex:feat/ot128-imu

Conversation

@mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 3, 2025

PR Type

  • New Feature

Related Links

Description

IMU output support for Hesai OT128.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex self-assigned this Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.08%. Comparing base (dfc188d) to head (005118e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   34.06%   34.08%   +0.02%     
==========================================
  Files         126      128       +2     
  Lines       10666    10735      +69     
  Branches     5509     5538      +29     
==========================================
+ Hits         3633     3659      +26     
- Misses       6375     6411      +36     
- Partials      658      665       +7     
Flag Coverage Δ
differential 34.08% <37.73%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 54.15% <ø> (ø)
Hesai 31.39% <37.73%> (+0.04%) ⬆️
Velodyne 40.14% <ø> (ø)
Continental 32.24% <ø> (+0.09%) ⬆️
Robosense 5.74% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant