Skip to content

-Point2 class added to support nano and micro seconds insert/get#68

Open
ummarbhutta wants to merge 1 commit intotihomir-kit:developfrom
ummarbhutta:feature_unixtimestamp
Open

-Point2 class added to support nano and micro seconds insert/get#68
ummarbhutta wants to merge 1 commit intotihomir-kit:developfrom
ummarbhutta:feature_unixtimestamp

Conversation

@ummarbhutta
Copy link

-Nano and microsecond support added

-Its responsilbility of client program to calculate the timestamp
@tihomir-kit
Copy link
Owner

Thanks for this. I'll use some bits of the code you made, but I'll have to refactor it. I want to avoid introducing an additional class Point2 which is essentially a duplicate just to support NS and MS, it would bring in confusion. The original Point class should support MS and NS.

@ummarbhutta
Copy link
Author

Hello @pootzko Thanks for your feedback. Couple of points why I implemented it in this way.

  1. In Point Timestamp is of type DateTime, and DateTime can't provide nano seconds resolution.
  2. I extend the Point class to add an additional timestamp field of type long, In my opinion adding this field to same Point class can add to confusion.
  3. I understand that playing with DateTime is very convenient in C#, but for nano seconds the user has to provide long value of nano seconds
  4. Change impact was lower.

Anyways I would be happy to provide any help if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants