Allow creating a GenericGaugeVec with Vec<String>#399
Open
vrmiguel wants to merge 1 commit intotikv:masterfrom
vrmiguel:generic-gauge-vec-from-vec
Open
Allow creating a GenericGaugeVec with Vec<String>#399vrmiguel wants to merge 1 commit intotikv:masterfrom vrmiguel:generic-gauge-vec-from-vec
vrmiguel wants to merge 1 commit intotikv:masterfrom
vrmiguel:generic-gauge-vec-from-vec
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericGaugeVec::new's need for&[&str]can lead to inefficient code such as what can be seen here in The Graph's code, where aVec<&str>is obtained from aVec<String>, which is then sent as a slice toGenericGaugeVec::new, who clones the contents of the slice in order to again obtain aVec<String>.All those allocations could be avoided if there were a way of creating
GenericGaugeVecwith aVec<String>directly, which is what this PR proposes.The usage of
GenericGaugeVec::newremains intact while aGenericGaugeVec::new_from_vecfunction has been added