feat!(atomic,value,gauge): return old value on increment#558
Open
lajp wants to merge 1 commit intotikv:masterfrom
Open
feat!(atomic,value,gauge): return old value on increment#558lajp wants to merge 1 commit intotikv:masterfrom
lajp wants to merge 1 commit intotikv:masterfrom
Conversation
|
Welcome @lajp! It looks like this is your first PR to tikv/rust-prometheus 🎉 |
lajp
force-pushed
the
atomic-return-old-value
branch
from
454c393 to
ac47a57
Compare
Signed-off-by: Luukas Pörtfors <luukas.portfors@braiins.cz>
lajp
force-pushed
the
atomic-return-old-value
branch
from
ac47a57 to
009d603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be useful if the
addandsubfunctions onGaugewould return the old value. Alternatively (and perhaps ideally), an API could be exposed to access the underlying atomic type from std.This is a BREAKING CHANGE, let me know what you think.