Skip to content

Conversation

@knopki
Copy link
Member

@knopki knopki commented Dec 13, 2025

Fixes of #20 + port to scikit-build-core. pyproject.toml is moved to the root. Editable install is supported. setuptools is dropped. Simplify cmake scripts.

Broken codacy action is dropped.

ilammy/msvc-dev-cmd action is broken. So, bundle fixed version of it until ilammy/msvc-dev-cmd#94 and ilammy/msvc-dev-cmd#95 are merged (or not).

cibuildwheel and repairwheel are used to build wheels as recommended in scikit-build-core's documentation. Now only the targets that were there before are being built. Then we can try adding macosx, arm, etc.

Summary by Bito

  • This pull request drops support for setuptools, which may introduce compatibility issues with existing setups.
  • It bundles a fixed version of the msvc-dev-cmd action to address broken actions in the CI/CD pipeline until upstream issues are resolved.
  • The project is ported to scikit-build-core, which includes moving the pyproject.toml file to the root directory and simplifying CMake scripts.
  • Overall, the changes involve porting to scikit-build-core, updating build configurations, and addressing CI/CD pipeline issues, which introduces potential compatibility risks.

@guardrails
Copy link

guardrails bot commented Dec 13, 2025

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:npm/eslint@7.32.0 (t) upgrade to: > 7.32.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@bito-code-review
Copy link

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at eb@tilde.pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant