Skip to content

fix: correct entity_client batch resolve request format and response parsing#26

Merged
seanfromthepast merged 1 commit intomainfrom
fix/entity-client-batch-resolve-format
Mar 25, 2026
Merged

fix: correct entity_client batch resolve request format and response parsing#26
seanfromthepast merged 1 commit intomainfrom
fix/entity-client-batch-resolve-format

Conversation

@realityinspector
Copy link
Collaborator

Summary

  • Request format: Clockchain /figures/batch-resolve expects {"names": [{"display_name": "...", "entity_type": "..."}]} — was incorrectly sending {"names": ["name1", "name2"], "entity_type": "person"}
  • Response parsing: Clockchain returns {"results": [{"figure": {"id": "...", "display_name": "..."}, "created": bool}]} — was incorrectly reading {"resolved": {"Name": "entity_id"}}
  • Unit tests updated to match correct contract

Activation

Set ENTITY_RESOLUTION_ENABLED=true on Railway when ready to enable in production pipeline.

@seanfromthepast seanfromthepast merged commit d78a69e into main Mar 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants