Draft
Conversation
Collaborator
Author
|
another option could be to have an global option similar to |
|
Is this still being considered as a feature? |
Collaborator
Author
|
this is a draft of an alternative to #222, it's probably not hard to finish (some copy-paste and testing). I might work on it when I have the time but if someone wants this feature faster, they can work on it |
Owner
|
Sorry no one has given this a review. This looks reasonable and I'd support merging it if someone added tests and docs. I prefer this implementation to #222. |
Collaborator
Author
|
This is still in progress, I will continue working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is could be an alternative to #222
this is based on what is already done for the
keepkeywordset
keepall=trueinnext!orupdate!for it to take effect (only forProgressright now, but it can easily be adapted toProgressTreshandProgressUnknown)if there are still escape characters in the output for the color, you can wrap the io in
IOContext(io, :color => false)