Add output buffering to avoid flickering#245
Open
ikirill wants to merge 1 commit intotimholy:masterfrom
Open
Conversation
Don’t write directly to stdout, it is not buffered and a sufficiently fast terminal will show partial progress bar writes.
Owner
|
Let's re-run the tests here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting quite a bit of flickering, especially when displaying values under the progress bar, so this patch tries to address that by putting all the output into an IOBuffer before writing it all at once.
In particular, the cursor was constantly moving back and forth (visibly!) between the beginning and the end of the line.