chore: replace through2 with node:stream#47
Open
SethFalco wants to merge 1 commit intotimkendrick:masterfrom
Open
chore: replace through2 with node:stream#47SethFalco wants to merge 1 commit intotimkendrick:masterfrom
through2 with node:stream#47SethFalco wants to merge 1 commit intotimkendrick:masterfrom
Conversation
through2 with node:stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates from the through2 npm package to standard Node.js
streamAPI. This is one less direct dependency, and speeds up what I think would be an organic flow for many users to follow anyway. (i.e. to read thethrough2documentation, then migrate tonode:stream)This is based on a recommendation which can be found on the
through2README.I followed that advice and we applied it to github.com/Vukory/thesis-frontend#eleventy.config.js, which worked out fine.
I originally only planned to amend the documentation, but I opted to amend the tests too, to be 100% sure that this interface can be used to pass all test cases defined.