Skip to content

Dashboard fixes for PHP 8.3#949

Closed
dalers wants to merge 3 commits into
timschofield:masterfrom
dalers:dashboard
Closed

Dashboard fixes for PHP 8.3#949
dalers wants to merge 3 commits into
timschofield:masterfrom
dalers:dashboard

Conversation

@dalers

@dalers dalers commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator
  1. corrects failing on PHP 8.3.6 due to uninitialized array variable "ScriptArray" (does not fail on 8.2.32)
  2. prevent incorrect 2nd insert causing SQL duplicate key error (hidden with production debug settings)
Function Call StackFrame File Line Function Class Arguments
0 /home/dale/weberp/includes/ConnectDB_mariadb.php 82 ShowDebugBackTrace N/A
Array
(
    [0] => The SQL that failed was
    [1] => INSERT INTO scripts (script,
                                pagesecurity,
                                description
                            ) VALUES (
                                'mrp_dashboard.php',
                                '1',
                                'MRP Status'
                            )
)

1/home/dale/weberp/DashboardConfig.php 70 DB_query N/A
Array
(
    [0] => INSERT INTO scripts (script,
                                pagesecurity,
                                description
                            ) VALUES (
                                'mrp_dashboard.php',
                                '1',
                                'MRP Status'
                            )
)
  1. added Copilot direction file for developing using VS Code on WSL Ubuntu and at least free plan for GitHub Copilot ("2,000 completions per month").

@dalers

dalers commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

The CI tests are failing again seemingly due to API issues. This seems like a repeat of my previous PR when the tests all failed due to API issues, and then @timschofield restarted the tests and they all passed.

I unfortunately can't see a way to re-start the tests myself, but suspect this actually a symptom of some bigger issues that we need to figure out.

@pakricard and @timschofield, I'd feel better if one of you reviewed the changes and merged the PR. Thanks! :-)

@dalers

dalers commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Found how to re-run the CI tests and now they all pass. One of these days I'll have to learn how they work.

@dalers

dalers commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

PR cancelled due to new commits, will send new PR based on current code.

@dalers dalers closed this Jul 8, 2026
@dalers dalers deleted the dashboard branch July 8, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant