feat(storage): implement backend sorting with sql injection protection#145
Open
Lutherwaves wants to merge 18 commits intomainfrom
Open
feat(storage): implement backend sorting with sql injection protection#145Lutherwaves wants to merge 18 commits intomainfrom
Lutherwaves wants to merge 18 commits intomainfrom
Conversation
ayashjorden
requested changes
Feb 20, 2026
…ge-level functions
Contributor
Author
|
@ayashjorden Thanks for the review, available for re-review. |
ayashjorden
reviewed
Feb 20, 2026
ayashjorden
reviewed
Feb 20, 2026
ayashjorden
approved these changes
Feb 20, 2026
deanefrati
reviewed
Feb 23, 2026
Lutherwaves
changed the title
…tsMaliciousSortKey
…interface Move user-facing documentation (struct field name requirement, sort direction param) to the exported List and Search interface methods where library consumers can discover it. Trim unexported executePaginatedQuery docs to maintainer notes.
Lutherwaves
force-pushed
the
fix/AddSortingSQLAdapter
branch
from
331a059 to
4b4931c
Compare
Lutherwaves
changed the title
Contributor
Author
|
@deanefrati @ayashjorden please take a look when you have time |
ayashjorden
reviewed
Feb 24, 2026
ayashjorden
reviewed
Feb 24, 2026
Contributor
Author
|
@ayashjorden @deanefrati ready for rereview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sortDirectionsupport to cursor-paginated queries across SQL, CosmosDB, and DynamoDB adaptersSortingDirectiontype withAscending/DescendingconstantssortKeyagainst a strict column-name whitelist before interpolation into ORDER BY clauses, closing an injection vector whereOrder()does not escape inputsslog.Warn— pagination that silently breaks now shows up in logssortKeyandSortDirectionKeyon the exportedStorageAdapterinterface following Google's Go style guideWhat's NOT in this PR
Replacing
params ...map[string]anywith typed options is deferred — it's an interface-breaking change across all downstream services, and the migration only pays for itself once a second cross-adapter param is added to the bag.