espflasher: add retry logic for flash block writes and fix compressed timeouts - #56
Merged
Conversation
… timeouts Add per-block retry (3 attempts) for both compressed and uncompressed flash writes, matching esptool.py's WRITE_BLOCK_ATTEMPTS behavior. Transient SLIP timeouts and framing errors are common during flashing and typically resolve on retry. The stub handles duplicate sequence numbers gracefully, so resending an already-processed block is safe. Fix the per-block timeout for compressed flash writes: the timeout was computed from the compressed block size, but the stub must decompress and write much more data before ACKing. Scale the timeout by the compression ratio so it reflects the actual flash write time. Fix retry desync: wait before flushing (not after) so a delayed response from the timed-out attempt arrives and gets cleared by the flush, preventing stale SLIP frames from corrupting the retry's response parsing. Signed-off-by: deadprogram <ron@hybridgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per-block retry (3 attempts) for both compressed and uncompressed flash writes, matching esptool.py's WRITE_BLOCK_ATTEMPTS behavior. Transient SLIP timeouts and framing errors are common during flashing and typically resolve on retry. The stub handles duplicate sequence numbers gracefully, so resending an already-processed block is safe.
Fix the per-block timeout for compressed flash writes: the timeout was computed from the compressed block size, but the stub must decompress and write much more data before ACKing. Scale the timeout by the compression ratio so it reflects the actual flash write time.
Fix retry desync: wait before flushing (not after) so a delayed response from the timed-out attempt arrives and gets cleared by the flush, preventing stale SLIP frames from corrupting the retry's response parsing.