-
Notifications
You must be signed in to change notification settings - Fork 360
fix(ollama): URL builder + local-AI noise suppression bundle #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c009b4e
fix(embeddings): harden ollama embed configuration
oxoxDev 07a3286
fix(providers): allow unauthenticated local ollama chat
oxoxDev 3bf6ba4
refactor(observability): demote expected local-ai config errors
oxoxDev 2c53e60
fix(app): gate local-ai runtime actions when disabled
oxoxDev 4dde399
fix(ollama): address review feedback
oxoxDev b16a2c4
Merge remote-tracking branch 'upstream/main' into pr/1553
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
app/src/components/settings/panels/__tests__/AIPanel.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { fireEvent, screen } from '@testing-library/react'; | ||
| import { beforeEach, describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import { renderWithProviders } from '../../../../test/test-utils'; | ||
| import { | ||
| aiGetConfig, | ||
| type AIPreview, | ||
| aiRefreshConfig, | ||
| type CommandResponse, | ||
| type LocalAiStatus, | ||
| openhumanLocalAiDownload, | ||
| openhumanLocalAiStatus, | ||
| } from '../../../../utils/tauriCommands'; | ||
| import AIPanel from '../AIPanel'; | ||
|
|
||
| vi.mock('../../../../utils/tauriCommands', () => ({ | ||
| aiGetConfig: vi.fn(), | ||
| aiRefreshConfig: vi.fn(), | ||
| openhumanLocalAiDownload: vi.fn(), | ||
| openhumanLocalAiStatus: vi.fn(), | ||
| })); | ||
|
|
||
| const aiPreview: AIPreview = { | ||
| soul: { | ||
| raw: '', | ||
| name: 'OpenHuman', | ||
| description: 'Test persona', | ||
| personalityPreview: [], | ||
| safetyRulesPreview: [], | ||
| loadedAt: 1, | ||
| }, | ||
| tools: { raw: '', totalTools: 0, activeSkills: 0, skillsPreview: [], loadedAt: 1 }, | ||
| metadata: { | ||
| loadedAt: 1, | ||
| loadingDuration: 1, | ||
| hasFallbacks: false, | ||
| sources: { soul: 'test', tools: 'test' }, | ||
| errors: [], | ||
| }, | ||
| }; | ||
|
|
||
| const disabledStatus: LocalAiStatus = { | ||
| state: 'disabled', | ||
| model_id: 'local-v1', | ||
| } as unknown as LocalAiStatus; | ||
|
|
||
| describe('AIPanel local model runtime gate', () => { | ||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| vi.mocked(aiGetConfig).mockResolvedValue(aiPreview); | ||
| vi.mocked(aiRefreshConfig).mockResolvedValue(aiPreview); | ||
| vi.mocked(openhumanLocalAiStatus).mockResolvedValue({ | ||
| result: disabledStatus, | ||
| logs: [], | ||
| } as CommandResponse<LocalAiStatus>); | ||
| vi.mocked(openhumanLocalAiDownload).mockResolvedValue({ | ||
| result: disabledStatus, | ||
| logs: [], | ||
| } as CommandResponse<LocalAiStatus>); | ||
| }); | ||
|
|
||
| it('does not retry downloads while local AI runtime is disabled', async () => { | ||
| renderWithProviders(<AIPanel />, { initialEntries: ['/settings/ai'] }); | ||
|
|
||
| const retryButton = await screen.findByRole('button', { name: 'Retry Download' }); | ||
| expect(retryButton).toBeDisabled(); | ||
| fireEvent.click(retryButton); | ||
|
|
||
| expect(openhumanLocalAiDownload).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
app/src/components/settings/panels/local-model/ModelDownloadSection.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import { fireEvent, render, screen } from '@testing-library/react'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import ModelDownloadSection from './ModelDownloadSection'; | ||
|
|
||
| const makeProps = () => ({ | ||
| assets: null, | ||
| assetDownloadBusy: {}, | ||
| statusTone: (_state: string) => '', | ||
| runtimeEnabled: false, | ||
| onTriggerAssetDownload: vi.fn(), | ||
| summaryInput: 'summarize me', | ||
| summaryOutput: '', | ||
| isSummaryLoading: false, | ||
| onSetSummaryInput: vi.fn(), | ||
| onRunSummaryTest: vi.fn(), | ||
| promptInput: 'prompt', | ||
| promptOutput: '', | ||
| promptError: '', | ||
| isPromptLoading: false, | ||
| promptNoThink: true, | ||
| onSetPromptInput: vi.fn(), | ||
| onSetPromptNoThink: vi.fn(), | ||
| onRunPromptTest: vi.fn(), | ||
| visionPromptInput: 'what is this?', | ||
| visionImageInput: 'image-ref', | ||
| visionOutput: '', | ||
| isVisionLoading: false, | ||
| onSetVisionPromptInput: vi.fn(), | ||
| onSetVisionImageInput: vi.fn(), | ||
| onRunVisionTest: vi.fn(), | ||
| embeddingInput: 'one line', | ||
| embeddingOutput: null, | ||
| isEmbeddingLoading: false, | ||
| onSetEmbeddingInput: vi.fn(), | ||
| onRunEmbeddingTest: vi.fn(), | ||
| audioPathInput: '/tmp/audio.wav', | ||
| transcribeOutput: null, | ||
| isTranscribeLoading: false, | ||
| onSetAudioPathInput: vi.fn(), | ||
| onRunTranscribeTest: vi.fn(), | ||
| ttsInput: 'say this', | ||
| ttsOutputPath: '', | ||
| ttsOutput: null, | ||
| isTtsLoading: false, | ||
| onSetTtsInput: vi.fn(), | ||
| onSetTtsOutputPath: vi.fn(), | ||
| onRunTtsTest: vi.fn(), | ||
| }); | ||
|
|
||
| describe('ModelDownloadSection runtime gate', () => { | ||
| it('does not invoke local-AI test actions when runtime is disabled', () => { | ||
| const props = makeProps(); | ||
| render(<ModelDownloadSection {...props} />); | ||
|
|
||
| const summaryButton = screen.getByRole('button', { name: 'Run Summary Test' }); | ||
| expect(summaryButton).toBeDisabled(); | ||
| fireEvent.click(summaryButton); | ||
|
|
||
| const promptButton = screen.getByRole('button', { name: 'Run Prompt Test' }); | ||
| expect(promptButton).toBeDisabled(); | ||
| fireEvent.click(promptButton); | ||
|
|
||
| expect(props.onRunSummaryTest).not.toHaveBeenCalled(); | ||
| expect(props.onRunPromptTest).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.