fix(conversations): add required seq to ToolTimelineEntry test fixtures (fixes red main, #4948)#4949
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Summary
mainis currently RED — theFrontend Checks (quality, i18n, docs, coverage)lane fails to typecheck, which hard-blocks every open PR. This restores it.seq: 0field to the twoToolTimelineEntrytest fixtures inapp/src/pages/__tests__/Conversations.render.test.tsx(lines 2414 and 2438).Problem
mainfailstsc --noEmitwith twoTS2741errors:Root cause — a semantic conflict between two individually-green PRs:
b48b62327) added two newToolTimelineEntryfixtures toConversations.render.test.tsx.4a68fd727) madeseq: numberrequired onToolTimelineEntry(app/src/store/chatRuntimeSlice.ts:286) and updated 12 test files to addseq— but it was authored against a base predating fix(conversations): key the proactive-thread insights fallback (disclosure state leak) #4944, so it never saw these two fixtures.Both passed CI in isolation; once both landed on
main, the two fixtures lack the newly-requiredseqand the typecheck lane breaks. Full writeup in #4948.Solution
seq: 0to each of the two fixtures, placed afterroundand beforestatus— matching fix(flows): stable issue-order for tool-call timeline (monotonic seq + FIFO result pairing) #4945's own convention for every comparable single-entry fixture it updated (timeline/selectors.test.ts,SubMascotLayer.test.tsx,ToolTimelineBlock.test.tsx).ToolTimelineEntry-shaped object literal inapp/srcand confirmed the only strictly-typed ones missingseqwere these two. All otherround:+status:literals surfaced by the sweep are eitheras-cast to a looser param type (ChatRuntimeProvider.test.tsx,WorkflowCopilotPanel.test.tsx) or belong to loosely-typed mock/snapshot fields, so they do not requireseq. Definitively confirmed by a clean fulltsc --noEmitafter the fix (0 errors).Submission Checklist
N/A: test-fixture-only change, no feature rows affected.## Related—N/A: no feature behavior changed.N/A: test-only.Closes #NNNin the## Relatedsection.Impact
Frontend Checkstypecheck lane onmain, unblocking every open PR (notably feat(core): compile-time flows feature gate (#4797) #4912, feat(core): compile-time skills feature gate (#4798) #4913, feat(core): compile-time mcp feature gate (#4799) #4914, fix(build): forward tokenjuice-treesitter + gate feature-forwarding drift in CI (#4918, #4919) #4934).*.test.tsxfixture.Related
main)AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/GH-4948-tooltimeline-seq-fixtures1e43cc4182d3643e59b37f46f38eb61767d9c89eValidation Run
pnpm --filter openhuman-app format:check— not run (two-line fixture edit; keys placed to match surrounding style).pnpm typecheck— passes clean (0 errors); this is the exact lane that was red onmain.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
seqfield was added.Duplicate / Superseded PR Handling