chore(core): drop the unused direct sha1 dependency (#5056) - #5100
Closed
graycyrus wants to merge 1 commit into
Closed
chore(core): drop the unused direct sha1 dependency (#5056)#5100graycyrus wants to merge 1 commit into
graycyrus wants to merge 1 commit into
Conversation
`sha1` was declared as a direct dependency only for legacy Tencent COS HMAC-SHA1 signing (yuanbao channel media upload), which now lives in the `tinychannels` crate. It has zero references in this crate (no `sha1::`, `use sha1`, `Sha1`, or `Hmac<Sha1>` use-sites). `hmac` stays — it is still used by x402 / clob_auth / tinyplace. `sha1` remains in Cargo.lock transitively for other crates that need it; only our unused direct edge is removed. The other zero-reference dependencies from the tinyhumansai#5056 audit (the OpenTelemetry trio, prost, postgres, ripemd, unicode-normalization, prometheus, dialoguer, clap_complete, shellexpand) were already removed upstream by tinyhumansai#5052. `webpki-roots` is intentionally kept — it backs the `rustls-tls-webpki-roots` TLS feature and is a load-bearing pin despite no direct reference. Verified: cargo check passes (media ON + disabled gate). Rank 5 (tail) of the tinyhumansai#5056 cleanup audit; complements tinyhumansai#5051/tinyhumansai#5052.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha1dependency from the coreCargo.toml.sha1has zero use-sites in this crate; it stays inCargo.locktransitively for crates that do need it.Problem
sha1was declared as a direct dependency only for legacy Tencent COS HMAC-SHA1 signing (yuanbao channel media upload), which now lives in thetinychannelscrate. It is the last zero-reference dependency from the #5056 cleanup audit — the OpenTelemetry trio,prost,postgres,ripemd,unicode-normalization,prometheus,dialoguer,clap_complete, andshellexpandwere already removed upstream by #5052.Solution
sha1 = "0.10"and its stale comment from[dependencies].Cargo.lock(only the direct edge is removed;sha1remains transitively).hmacis kept — still used by x402 / clob_auth / tinyplace (HMAC-SHA256 etc.).webpki-rootsis intentionally not removed: it backs therustls-tls-webpki-rootsTLS feature (tokio-tungstenite) and is a load-bearing version pin despite having no direct code reference.Verified zero use-sites: no
sha1::,use sha1,Sha1, orHmac<Sha1>anywhere insrc/,tests/, orexamples/.Submission Checklist
N/A: dependency-manifest change, no code paths added/removed.N/A: no executable lines changed.N/A: no feature change.## RelatedN/A: build-only change.## Related(does not close Remove unused/redundant features: screen intelligence, order complete, desktop automation, autocomplete, Whisper, unnecessary runtimes #5056).Impact
cargo checkpasses withmediaON and the disabled gate.Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fixes/rm-zero-ref-depsValidation Run
pnpm --filter openhuman-app format:check— N/A (no app changes)pnpm typecheck— N/A (no TS changes)cargo checkmedia ON + disabled gate both passBehavior Changes
Parity Contract
Duplicate / Superseded PR Handling