Skip to content

chore(core): drop the unused direct sha1 dependency (#5056) - #5100

Closed
graycyrus wants to merge 1 commit into
tinyhumansai:mainfrom
graycyrus:fixes/rm-zero-ref-deps
Closed

chore(core): drop the unused direct sha1 dependency (#5056)#5100
graycyrus wants to merge 1 commit into
tinyhumansai:mainfrom
graycyrus:fixes/rm-zero-ref-deps

Conversation

@graycyrus

Copy link
Copy Markdown
Contributor

Summary

  • Remove the unused direct sha1 dependency from the core Cargo.toml.
  • No behaviour change: sha1 has zero use-sites in this crate; it stays in Cargo.lock transitively for crates that do need it.

Problem

sha1 was declared as a direct dependency only for legacy Tencent COS HMAC-SHA1 signing (yuanbao channel media upload), which now lives in the tinychannels crate. It is the last zero-reference dependency from the #5056 cleanup audit — the OpenTelemetry trio, prost, postgres, ripemd, unicode-normalization, prometheus, dialoguer, clap_complete, and shellexpand were already removed upstream by #5052.

Solution

  • Drop sha1 = "0.10" and its stale comment from [dependencies].
  • Regenerate Cargo.lock (only the direct edge is removed; sha1 remains transitively).
  • hmac is kept — still used by x402 / clob_auth / tinyplace (HMAC-SHA256 etc.).
  • webpki-roots is intentionally not removed: it backs the rustls-tls-webpki-roots TLS feature (tokio-tungstenite) and is a load-bearing version pin despite having no direct code reference.

Verified zero use-sites: no sha1::, use sha1, Sha1, or Hmac<Sha1> anywhere in src/, tests/, or examples/.

Submission Checklist

Impact

  • Runtime: none.
  • Build: one fewer direct dependency edge. cargo check passes with media ON and the disabled gate.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: fixes/rm-zero-ref-deps
  • Commit SHA: 2b3d844

Validation Run

  • pnpm --filter openhuman-app format:check — N/A (no app changes)
  • pnpm typecheck — N/A (no TS changes)
  • Focused tests: cargo check media ON + disabled gate both pass
  • Rust fmt/check (if changed): no Rust source changed (manifest only)
  • Tauri fmt/check (if changed): N/A

Behavior Changes

  • Intended behavior change: none (removes an unused direct dependency edge)
  • User-visible effect: none

Parity Contract

  • Legacy behavior preserved: yes — sha1 had no use-sites; hmac + webpki-roots retained
  • Guard/fallback/dispatch parity checks: N/A

Duplicate / Superseded PR Handling

`sha1` was declared as a direct dependency only for legacy Tencent COS
HMAC-SHA1 signing (yuanbao channel media upload), which now lives in the
`tinychannels` crate. It has zero references in this crate (no `sha1::`,
`use sha1`, `Sha1`, or `Hmac<Sha1>` use-sites). `hmac` stays — it is still
used by x402 / clob_auth / tinyplace. `sha1` remains in Cargo.lock
transitively for other crates that need it; only our unused direct edge is
removed.

The other zero-reference dependencies from the tinyhumansai#5056 audit (the
OpenTelemetry trio, prost, postgres, ripemd, unicode-normalization,
prometheus, dialoguer, clap_complete, shellexpand) were already removed
upstream by tinyhumansai#5052. `webpki-roots` is intentionally kept — it backs the
`rustls-tls-webpki-roots` TLS feature and is a load-bearing pin despite no
direct reference.

Verified: cargo check passes (media ON + disabled gate).

Rank 5 (tail) of the tinyhumansai#5056 cleanup audit; complements tinyhumansai#5051/tinyhumansai#5052.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0a2cf9b-ade3-4034-abf8-c7e73e0fd4c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused/redundant features: screen intelligence, order complete, desktop automation, autocomplete, Whisper, unnecessary runtimes

2 participants