-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(kernel): gate the managed Node.js runtime behind runtime-node
#5397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a0d5d3f
feat(kernel): gate the managed Node.js runtime behind `runtime-node`
senamakel c914ee3
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/5397
senamakel ee03d54
chore: files changed src/openhuman/runtime/node/mod.rs
senamakel 5809b18
chore: files changed src/openhuman/runtime/node/stub.rs
senamakel e3abb51
chore: files changed src/openhuman/agent/harness_init/registry.rs
senamakel 977ccba
chore: files changed .github/workflows/ci-lite.yml
senamakel 5639213
chore: files changed AGENTS.md
senamakel 3853fdd
chore: files changed Cargo.toml
senamakel 11fd0e2
chore: files changed src/openhuman/agent/harness_init/registry.rs
senamakel 4d7a817
merge: resolve upstream/main conflicts for runtime-node gate
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule tauri-cef
added at
455b47
Submodule tauri-plugin-notification
added at
5f6196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a
--no-default-features --features flowskernel build,src/openhuman/runtime/pool/mod.rsstill declarespub mod nodeunconditionally, so embedders retain the publicrun_inlineNode execution API and the embeddedpool_worker.jseven though this feature's declared scope includesruntime::pool::node. Gate that module and its Node-only tests behindruntime-nodeso the off build actually removes the promised compile-time surface.AGENTS.md reference: AGENTS.md:L338-L338
Useful? React with 👍 / 👎.