Skip to content

Fix WriteBytes/WriteString/WriteStringFromBytes limit #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klauspost merged 1 commit into from
Dec 4, 2025
+3 −3
Merged

Fix WriteBytes/WriteString/WriteStringFromBytes limit #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions msgp/write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ func (mw *Writer) WriteUint(u uint) error { return mw.WriteUint64(uint64(u)) }

// WriteBytes writes binary as 'bin' to the writer
func (mw *Writer) WriteBytes(b []byte) error {
if uint64(len(b)) > math.MaxInt32 {
if uint64(len(b)) > math.MaxUint32 {
return ErrLimitExceeded
}
sz := uint32(len(b))
Expand Down Expand Up @@ -493,7 +493,7 @@ func (mw *Writer) WriteBool(b bool) error {
// WriteString writes a messagepack string to the writer.
// (This is NOT an implementation of io.StringWriter)
func (mw *Writer) WriteString(s string) error {
if uint64(len(s)) > math.MaxInt32 {
if uint64(len(s)) > math.MaxUint32 {
return ErrLimitExceeded
}

Expand Down Expand Up @@ -535,7 +535,7 @@ func (mw *Writer) WriteStringHeader(sz uint32) error {
// WriteStringFromBytes writes a 'str' object
// from a []byte.
func (mw *Writer) WriteStringFromBytes(str []byte) error {
if uint64(len(str)) > math.MaxInt32 {
if uint64(len(str)) > math.MaxUint32 {
return ErrLimitExceeded
}
sz := uint32(len(str))
Expand Down
Loading