Skip to content

fix: cursor jumping at the beginning #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidediak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: cursor jumping at the beginning #371

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c7808e
fix: cursor jumping at the beginning
davidediak Feb 7, 2024
da83820
test: fixed breaking test and add test for FormControl cursor issue
davidediak Mar 28, 2024
142b88e
Merge remote-tracking branch 'origin/main' into 321-fix-cursor-jumps-…
davidediak May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tinymce-angular-component/src/main/ts/editor/editor.component.ts
View file
Open in desktop
Copy link

@joe-baudisch joe-baudisch Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const cursor = this._editor.selection.getBookmark(3) as any
if (cursor['start'] && cursor['start'].startsWith('text()')) {
// do nothing because the cursor initially jumps back to first line with 'text()'
// while pasting in text from outside; moving to this bookmark after set content
// creates this cursor jump which should be avoided;
// if you paste in text from inside the editor or write text by keyboard
// the cursor starts with a paragraph tag created by TMCE like
// 'p[element_index]/text()[0]'
} else {
this._editor.setContent(isNullOrUndefined(value) ? '' : value);
try {
this._editor.selection.moveToBookmark(cursor);
} catch (e) {
/* ignore */
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ export class EditorComponent extends Events implements AfterViewInit, ControlVal

public writeValue(value: string | null): void {
if (this._editor && this._editor.initialized) {
const cursor = this._editor.selection.getBookmark(3);
this._editor.setContent(isNullOrUndefined(value) ? '' : value);
this._editor.selection.moveToBookmark(cursor);
} else {
this.initialValue = value === null ? undefined : value;
}
Expand Down