Set active stripe account for both account and member#126
Draft
DaniyarAskarov wants to merge 10 commits intomasterfrom
Draft
Set active stripe account for both account and member#126DaniyarAskarov wants to merge 10 commits intomasterfrom
DaniyarAskarov wants to merge 10 commits intomasterfrom
Conversation
kirillta
reviewed
Feb 6, 2022
| Task<Result> AddForMember(MemberRequest request, CancellationToken cancellationToken); | ||
| Task<Result> AddForAccount(Account request, CancellationToken cancellationToken); | ||
| Task<Result> AttachDefaultExternal(PayoutMethodRequest request, CancellationToken cancellationToken); | ||
| Task<Result> SetStripeAccountActive(string accountId, int memberId, CancellationToken cancellationToken); |
Member
There was a problem hiding this comment.
SetActiveStripeAccount is better
| public async Task<Result> SetStripeAccountActive(string stripeAccountId, int memberId, CancellationToken cancellationToken) | ||
| { | ||
| var targetMember = await _context.Members | ||
| .SingleAsync(m => m.Id == memberId, cancellationToken); |
|
|
||
|
|
||
|
|
||
| public async Task<Result> SetStripeAccountActive(string stripeAccountId, int memberId, CancellationToken cancellationToken) |
kirillta
approved these changes
Feb 9, 2022
| @@ -9,9 +9,9 @@ namespace TipCatDotNet.Api.Services.Payments; | |||
| public interface IStripeAccountService | |||
| { | |||
| Task<Result> AddForMember(MemberRequest request, CancellationToken cancellationToken); | |||
Member
There was a problem hiding this comment.
This one could be just Add after changes in AddForAccountAndManager name
kirillta
approved these changes
Feb 9, 2022
kirillta
reviewed
Feb 11, 2022
| [Flags] | ||
| public enum ActiveStripeAccountType | ||
| { | ||
| Organizational = 1, |
Member
There was a problem hiding this comment.
Better add a default value, like Undefined = 0, because of enum casting issues
Member
There was a problem hiding this comment.
I think ...stripe-account/set-active is better to PUT
Member
There was a problem hiding this comment.
Do we allow empty strings as account IDs? If not, you may use null here for simplicity
kirillta
approved these changes
Feb 11, 2022
kirillta
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.