Open
Conversation
Removed default parameters and tweaked function accordingly to allow compatibility with node core < v6.0
Hoping to get this feature implemented.
fix setting max results in constructor
Removed some things I thought were quite confusing in the examples. For example, upon reading the source code I found that `createSearch` does not return a value, and yet the example had `var search = createSearch(...`
Improve examples
There was a bug in the code that made it impossible to change the limits of the search, so it returns a different number of records.
Fix limits of search
Initial CI
Add badges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
when I try to test the examples the console reports an error: property 'index' undefined
what comes from what please?
Thank you