Skip to content

Conversation

@leeland-turnkey
Copy link
Contributor

@leeland-turnkey leeland-turnkey commented Dec 17, 2025

We have an additional listener that is a duplicate of code that is already running in event-handler.js file. This code in index.js file is a duplicate of what is running in this code

TURNKEY_INIT_MESSAGE_CHANNEL is handled by initEventHandlers() which is called in DOMContentLoaded above.
The initEventHandlers function sets up a message listener for TURNKEY_INIT_MESSAGE_CHANNEL internally.

Here is a color representation of the logs before and after the delete.

Before:
Color map of console.log

Screenshot 2025-12-17 at 1 41 07 PM

After:
Color map of console.log

Screenshot 2025-12-17 at 1 42 44 PM

@leeland-turnkey leeland-turnkey changed the title Remove additional listener Remove additional listener in export-and-sign Dec 17, 2025
ethankonk
ethankonk previously approved these changes Dec 17, 2025
Copy link
Contributor

@ethankonk ethankonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some merge conflicts you'll have to fix but looks great so far!

@leeland-turnkey
Copy link
Contributor Author

@ethankonk Pulled in main so it should be good to go!

@leeland-turnkey leeland-turnkey merged commit 12dc3d6 into main Dec 18, 2025
9 checks passed
@leeland-turnkey leeland-turnkey deleted the leeland/eng-2785-tob-52-redundant-event-listener-in-export-and-sign branch December 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants