Custom ttl for init embedded key #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
reviewed
Mar 11, 2025
r-n-o
reviewed
Mar 11, 2025
auth/index.html
Outdated
Comment on lines
1167
to
1171
| if (event.data.dangerouslyOverrideIframeKeyTtl) { | ||
| await TKHQ.initEmbeddedKey(event.data.dangerouslyOverrideIframeKeyTtl); | ||
| } else { | ||
| await TKHQ.initEmbeddedKey(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Let's do validation to make sure the TTL passed is a number. In JS a lot of stuff is truthy.
I'd also like to simplify TKHQ.initEmbeddedKey so that it always expects an argument (the TTL). And here we can have:
var iframeKeyTtl = TURNKEY_EMBEDDED_KEY_TTL_IN_MILLIS
if (event.data.dangerouslyOverrideIframeKeyTtl && ...validation...) {
iframeKeyTtl = event.data.dangerouslyOverrideIframeKeyTtl;
}
await TKHQ.initEmbeddedKey(iframeKeyTtl);
r-n-o
reviewed
Mar 11, 2025
r-n-o
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to: tkhq/sdk#535