Skip to content

fix: add missing headers for acwing solution #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkzzzzzz6 merged 1 commit into from
Apr 16, 2026
+2 −0
Merged

fix: add missing headers for acwing solution #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions acwing/剑指 offer/13. 找出数组中重复的数字/3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#include <vector>
#include <algorithm>
Comment on lines +1 to +2
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

find . -type f -name "3.cpp" | grep -i "找出数组中重复的数字"

Repository: tkzzzzzz6/Algorithm_beginner_learning_notes

Length of output: 125

🏁 Script executed:

cat -n "./acwing/剑指 offer/13. 找出数组中重复的数字/3.cpp"

Repository: tkzzzzzz6/Algorithm_beginner_learning_notes

Length of output: 738

Namespace qualification is missing—code will not compile.

Adding the headers is correct, but lines 11 and 14 use vector and sort without std:: qualification, and the file has no using namespace std; declaration. This causes a compilation error.

Proposed fix 
 class Solution {
 public:
-    int duplicateInArray(vector<int>& nums) {
+    int duplicateInArray(std::vector<int>& nums) {
         int n = nums.size();
         if(n == 0)return -1;
-        sort(nums.begin(),nums.end());
+        std::sort(nums.begin(),nums.end());
         if(nums[0] < 0 || nums[n-1] >= n)return -1;
         for(int i = 1;i<n;++i){
             if(nums[i-1] == nums[i])return nums[i];
         }
         return -1;
     }
 };
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#include <vector>
#include <algorithm>
`#include` <vector>
`#include` <algorithm>
class Solution {
public:
int duplicateInArray(std::vector<int>& nums) {
int n = nums.size();
if(n == 0)return -1;
std::sort(nums.begin(),nums.end());
if(nums[0] < 0 || nums[n-1] >= n)return -1;
for(int i = 1;i<n;++i){
if(nums[i-1] == nums[i])return nums[i];
}
return -1;
}
};
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@acwing/剑指` offer/13. 找出数组中重复的数字/3.cpp around lines 1 - 2, The code uses
unqualified symbols vector and sort (seen in this file's use of vector and sort)
but the headers are included without a using directive, so the compiler will
fail; fix by qualifying these symbols with the std:: namespace (e.g., replace
vector with std::vector and sort with std::sort) or add an explicit using
declaration (e.g., using std::vector; using std::sort; or using namespace std;)
at the top—update occurrences in functions that reference vector and sort to use
the chosen approach (look for usages in this file such as where vector and sort
are invoked) so the file compiles.

/*
* @Author: tkzzzzzz6
* @Date: 2026-04-13 10:45:59
Expand Down
Loading