Skip to content

Commit 3dd8a21

Browse files
committed
fixed a group selection bug
1 parent 39cdc6e commit 3dd8a21

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/certificate/CertificateKeyPair.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ public void adjustInContext(TlsContext context, ConnectionEndType connectionEnd)
359359
if (privateKey != null) {
360360
privateKey.adjustInContext(context, connectionEnd);
361361
}
362-
context.setSelectedGroup(publicKeyGroup);
362+
context.setEcCertificateCurve(publicKeyGroup);
363363
if (context.getConfig().getAutoAdjustSignatureAndHashAlgorithm()) {
364364
// TODO rething auto selection
365365
SignatureAlgorithm signatureAlgorithm = SignatureAlgorithm.RSA;

TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/crypto/keys/CustomECPrivateKey.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ public void adjustInContext(TlsContext context, ConnectionEndType ownerOfKey) {
8585
switch (ownerOfKey) {
8686
case CLIENT:
8787
context.setClientEcPrivateKey(privatekey);
88-
context.setSelectedGroup(group);
88+
context.setEcCertificateCurve(group);
8989
break;
9090
case SERVER:
9191
context.setServerEcPrivateKey(privatekey);
92-
context.setSelectedGroup(group);
92+
context.setEcCertificateCurve(group);
9393
break;
9494
default:
9595
throw new IllegalArgumentException("Owner of Key " + ownerOfKey + " is not supported");
@@ -105,11 +105,11 @@ public void adjustInConfig(Config config, ConnectionEndType ownerOfKey) {
105105
switch (ownerOfKey) {
106106
case CLIENT:
107107
config.setDefaultClientEcPrivateKey(privatekey);
108-
config.setDefaultSelectedNamedGroup(group);
108+
config.setDefaultEcCertificateCurve(group);
109109
break;
110110
case SERVER:
111111
config.setDefaultServerEcPrivateKey(privatekey);
112-
config.setDefaultSelectedNamedGroup(group);
112+
config.setDefaultEcCertificateCurve(group);
113113
break;
114114
default:
115115
throw new IllegalArgumentException("Owner of Key " + ownerOfKey + " is not supported");

TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/crypto/keys/CustomEcPublicKey.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,15 @@ public void adjustInContext(TlsContext context, ConnectionEndType ownerOfKey) {
7373
switch (ownerOfKey) {
7474
case CLIENT:
7575
context.setClientEcPublicKey(point);
76-
context.setSelectedGroup(group);
76+
if (group != null) {
77+
context.setEcCertificateCurve(group);
78+
}
7779
break;
7880
case SERVER:
7981
context.setServerEcPublicKey(point);
80-
context.setSelectedGroup(group);
82+
if (group != null) {
83+
context.setEcCertificateCurve(group);
84+
}
8185
break;
8286
default:
8387
throw new IllegalArgumentException("Owner of Key " + ownerOfKey + " is not supported");
@@ -125,11 +129,15 @@ public void adjustInConfig(Config config, ConnectionEndType ownerOfKey) {
125129
switch (ownerOfKey) {
126130
case CLIENT:
127131
config.setDefaultClientEcPublicKey(point);
128-
config.setDefaultSelectedNamedGroup(group);
132+
if (group != null) {
133+
config.setDefaultEcCertificateCurve(group);
134+
}
129135
break;
130136
case SERVER:
131137
config.setDefaultServerEcPublicKey(point);
132-
config.setDefaultSelectedNamedGroup(group);
138+
if (group != null) {
139+
config.setDefaultEcCertificateCurve(group);
140+
}
133141
break;
134142
default:
135143
throw new IllegalArgumentException("Owner of Key " + ownerOfKey + " is not supported");

0 commit comments

Comments
 (0)