Fix checkbox returning empty string on Alt-Enter#515
Open
uttam12331 wants to merge 1 commit into
Open
Conversation
In a checkbox prompt, submitting with Alt-Enter (Meta+Enter) returned the empty string instead of the list of selected values, because only plain Enter (Keys.ControlM) was bound to the submission handler; the 'escape, c-m' sequence fell through to the default and returned ''. Bind the Alt-Enter sequence (Keys.Escape, Keys.ControlM) to the same set_answer handler so it submits and returns the selected values like Enter. Closes tmbo#324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #324.
In a
checkboxprompt, submitting with Alt-Enter (Meta+Enter) returns the empty string""instead of the list of selected values. Only plain Enter (Keys.ControlM) was bound to the submission handler, so theescape, c-msequence fell through to the default and returned"".Reproduction (before the fix):
Fix
Bind the Alt-Enter sequence (
Keys.Escape, Keys.ControlM) to the sameset_answerhandler as plain Enter, so it submits and returns the selected values:Tests
Added
test_select_first_choice_with_alt_enterasserting Alt-Enter returns['foo'](matching the plain-Enter behavior).Verified locally:
pytest tests/prompts/test_checkbox.py→ 34 passed;ruff checkclean.