Skip to content
This repository was archived by the owner on Jun 27, 2024. It is now read-only.

Conversation

@shao1555
Copy link

in current version, application statistics always returns as zipped CSV file.
so I've make some modification to this library.

  • retrieve CSV file, extract it (if need), then returns merged "ApplicationStatistics" model.
  • add find / select features for collections of ApplicationStatistics
  • write configuration in any context (like aws/aws-sdk-ruby)
  • to reliable spec test, use WebMock instead of your custom mock class.

sorry for my poor code and english.

@shao1555
Copy link
Author

no one is assigned?

@tmurakam
Copy link
Owner

Thanks. Your pull request was merged to features/application-statistics-model branch.
(Not yet merged to develop / master branch).

Whould you like to update ChangeLog file?

@shao1555
Copy link
Author

thank you for your reviewing.

I've added ChangeLog file. but I don't know rules for version number in this project, so place version number to "x.x.x" .
please update version number in ChangeLog and change gemspec file after merge this.

@shao1555
Copy link
Author

please merge it or give me some suggestion.

@tmurakam
Copy link
Owner

Merged to features/application-statistics-model branch.

@tmurakam
Copy link
Owner

I inspected your code, and found some issues.

  1. Your code does not work for HTTP proxy environments.
    You must set configuration BEFORE call Scraper.new, because proxy configuration is read only when constructor of Scraper is called.

  2. You changed config and agent to singleton, but I think this is not necessary change and I dislike this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants