Froglet Error Message Changes #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added error messages to *, ^, ~, and &. also added a new error message for |.
changed error messages to format of: The `&` operator is not used in Froglet, but is reserved for use in other Forge languages. If you meant intersection, use `and` or `&&` instead.
tnelson
reviewed
Apr 29, 2025
| (when (eq? (nodeinfo-lang (node-info expr-node)) LANG_ID) | ||
| (define loc (nodeinfo-loc (node-info expr-node))) | ||
| (raise-bsl-relational-error "&" expr-node loc))) | ||
| (raise-bsl-relational-error "&" expr-node loc "The `&` operator is not used in Froglet, but is reserved for use in other Forge languages. If you meant intersection, use `and` or `&&` instead."))) |
Owner
There was a problem hiding this comment.
"If you meant logical and..." (since intersection is not allowed, we don't want to bring that up)
tnelson
reviewed
Apr 29, 2025
| (raise-bsl-relational-error "&" expr-node loc))) | ||
| (raise-bsl-relational-error "&" expr-node loc "The `&` operator is not used in Froglet, but is reserved for use in other Forge languages. If you meant intersection, use `and` or `&&` instead."))) | ||
|
|
||
| (define (check-node-expr-op-| expr-node node-type child-types) |
Owner
There was a problem hiding this comment.
Confirm this is being registered with the lang-specific error framework. ( The | character isn't an operator, it's a reserved token. ) This seems like something we might want to include in the parser errors, when we can make them.
tnelson
reviewed
Apr 29, 2025
| (raise-bsl-relational-error-expr-args "&" expr-args loc))) | ||
| (raise-bsl-relational-error-expr-args "&" expr-args loc "The `&` operator is not used in Froglet, but is reserved for use in other Forge languages. If you meant intersection, use `and` or `&&` instead."))) | ||
|
|
||
| (define (check-args-node-expr-op-| expr-args info) |
Owner
There was a problem hiding this comment.
Similar to comment for | case above.
updated error changes after review
shoujohnny
commented
May 5, 2025
Author
shoujohnny
left a comment
shoujohnny
left a comment
There was a problem hiding this comment.
adjusted error messages in response to feedback!
Owner
|
Redirecting this to a feature branch so I can adjust error test cases without putting |
tnelson
added a commit
that referenced
this pull request
Nov 13, 2025
* fix: join parsing, regression test, note on 2nd issue * add: semantics test * add: tests, no-op change to parser for readability * add: revisions to get core (strings, for the moment) to sterling * fix: unsat but no core * stop sending core in place of source * Froglet Error Message Changes (#306) * update: error messages --------- Co-authored-by: shoujohnny <johnson_shou@brown.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
^operator is not used in Froglet, but is reserved for use in other Forge languages. If you meant exclusive-or, use thexoroperator instead.The
->operator is only used for field declaration in Froglet.Used this format