-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(exasol)!: qualified select list with "LOCAL" #6450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
6c22fc9
441215e
4953a60
6c341ac
6868e7d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -682,7 +682,14 @@ def test_local_prefix_for_alias(self): | |||||||||||||||
| self.validate_identity( | ||||||||||||||||
| 'SELECT YEAR(a_date) AS "a_year" FROM MY_SUMMARY_TABLE GROUP BY LOCAL."a_year"', | ||||||||||||||||
| ) | ||||||||||||||||
| self.validate_identity('SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year') | ||||||||||||||||
| self.validate_identity( | ||||||||||||||||
| 'SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year', | ||||||||||||||||
| 'SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year', | ||||||||||||||||
| ) | ||||||||||||||||
|
||||||||||||||||
| self.validate_identity( | |
| 'SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year', | |
| 'SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year', | |
| ) | |
| self.validate_identity( | |
| 'SELECT a_year AS a_year FROM "LOCAL" GROUP BY "LOCAL".a_year' | |
| ) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the input query work on Exasol? If not, we shouldn't be adding validate_identity that the input SQL does not work on that engine, those should be done through validate_all as you have done for DBX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaict this can be simplified to: