fix: encode volume content version in source prefix#279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People using volumes shoot themselves in the foot because of how
volumes updatecommand works. When they add a bunch of files to the directory they uploaded from previously they end up having a ton of files under the samesource_prefixin their volume they did not intend to have. This increases volume size and as a result coldstart time.This PR adds a version encoded into the
source_prefixof the volume so that update command always results in the files in distinct path we pull from in the tigris bucket. We anyways re-uploaded everything with update command even if the files already existed in the bucket, so no negative impact to UX.