Conversation
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @metalarm10, and @ysv).
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @ysv).
1d2f356
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @ysv).
miladz68
left a comment
There was a problem hiding this comment.
@miladz68 reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on metalarm10 and ysv).
Description
Backport PR#1173 from coreum.
This pull request adds support for burning the governance (bond) denom (such as
core,testcore, ordevcore) via the AssetFT module, in addition to existing AssetFT tokens. The changes include updating the keeper logic to allow this behavior, relaxing CLI and message validation, and adding comprehensive tests for both successful and failure scenarios when burning governance denoms.Governance denom burn support:
Keeper.Burnmethod to allow burning the governance/bond denom without requiring an AssetFT token definition, using the staking module to dynamically determine the bond denom. Burning is only allowed if the coins are not locked or restricted.MsgBurn.ValidateBasicto skip AssetFT-specific denom validation, so governance denoms (likeudevcore) can be burned; actual validation is deferred to the keeper.CLI and documentation improvements:
burnCLI command (CmdTxBurn) to document and support burning the governance/bond denom, with updated help text and usage examples.Testing:
Reviewers checklist:
Authors checklist
This change is