Skip to content

Backport Core burn from coreum repo#62

Merged
TxCorpi0x merged 8 commits intomasterfrom
mehdi/backport-core-burning
Feb 17, 2026
Merged

Backport Core burn from coreum repo#62
TxCorpi0x merged 8 commits intomasterfrom
mehdi/backport-core-burning

Conversation

@TxCorpi0x
Copy link
Contributor

@TxCorpi0x TxCorpi0x commented Jan 23, 2026

Description

Backport PR#1173 from coreum.

This pull request adds support for burning the governance (bond) denom (such as core, testcore, or devcore) via the AssetFT module, in addition to existing AssetFT tokens. The changes include updating the keeper logic to allow this behavior, relaxing CLI and message validation, and adding comprehensive tests for both successful and failure scenarios when burning governance denoms.

Governance denom burn support:

  • Updated the Keeper.Burn method to allow burning the governance/bond denom without requiring an AssetFT token definition, using the staking module to dynamically determine the bond denom. Burning is only allowed if the coins are not locked or restricted.
  • Relaxed MsgBurn.ValidateBasic to skip AssetFT-specific denom validation, so governance denoms (like udevcore) can be burned; actual validation is deferred to the keeper.

CLI and documentation improvements:

  • Enhanced the burn CLI command (CmdTxBurn) to document and support burning the governance/bond denom, with updated help text and usage examples.

Testing:

  • Added integration and CLI tests to verify burning the governance denom works as intended, including supply and balance checks. [1] [2]
  • Added extensive keeper unit tests covering successful burns, insufficient balance, zero/negative amounts, invalid denoms (IBC/random), module accounts, and locked coins for the governance denom.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner January 23, 2026 08:47
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, metalarm10, miladz68 and ysv and removed request for a team January 23, 2026 08:47
miladz68
miladz68 previously approved these changes Jan 29, 2026
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @metalarm10, and @ysv).

masihyeganeh
masihyeganeh previously approved these changes Feb 5, 2026
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @ysv).

@TxCorpi0x TxCorpi0x dismissed stale reviews from masihyeganeh and miladz68 via 1d2f356 February 11, 2026 10:18
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @metalarm10 and @ysv).

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on metalarm10 and ysv).

@TxCorpi0x TxCorpi0x merged commit 9f77d84 into master Feb 17, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments