Fix migrate-keyring CLI to include address reverse-lookup entries#89
Open
metalarm10 wants to merge 2 commits intomasterfrom
Open
Fix migrate-keyring CLI to include address reverse-lookup entries#89metalarm10 wants to merge 2 commits intomasterfrom
metalarm10 wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QA reported: After selective key migration (e.g.
txd keys migrate-keyring alice), the.infoentry (alice.info) was migrated successfully. Users could look up keys by name (--from alice). But lookups by bech32 address (--from testcore1k343...) failed with "key not found".This broke:
--from <address>flagThis PR fixes the issue: After migrating each
.infoentry, unmarshal the hex address, then migrate the corresponding<hex>.addressentry as well.Verified on coreum-testnet-1: key migration, address lookup, bank send with
--from <address>, and group proposal submission tests passed.Reviewers checklist:
Authors checklist
This change is