Skip to content

Comments

Fix migrate-keyring CLI to include address reverse-lookup entries#89

Open
metalarm10 wants to merge 2 commits intomasterfrom
john/fix-migrate-keyring-address-reverse-lookup
Open

Fix migrate-keyring CLI to include address reverse-lookup entries#89
metalarm10 wants to merge 2 commits intomasterfrom
john/fix-migrate-keyring-address-reverse-lookup

Conversation

@metalarm10
Copy link
Contributor

@metalarm10 metalarm10 commented Feb 20, 2026

Description

QA reported: After selective key migration (e.g. txd keys migrate-keyring alice), the .info entry (alice.info) was migrated successfully. Users could look up keys by name (--from alice). But lookups by bech32 address (--from testcore1k343...) failed with "key not found".

This broke:

  • Group proposal submission (proposers field uses bech32 addresses)
  • Transactions with --from <address> flag

This PR fixes the issue: After migrating each .info entry, unmarshal the hex address, then migrate the corresponding <hex>.address entry as well.

Verified on coreum-testnet-1: key migration, address lookup, bank send with --from <address>, and group proposal submission tests passed.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 requested a review from a team as a code owner February 20, 2026 11:24
@metalarm10 metalarm10 requested review from TxCorpi0x, masihyeganeh, miladz68 and ysv and removed request for a team February 20, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant