-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
docs: break up CONTRIBUTING.md
#7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTING.mdCONTRIBUTING.md
| ## LTS guarantees | ||
|
|
||
| Tokio ≥1.0.0 comes with LTS guarantees: | ||
|
|
||
| * A minimum of 5 years of maintenance. | ||
| * A minimum of 3 years before a hypothetical 2.0 release. | ||
| * A minimum of 5 years of maintenance. | ||
| * A minimum of 3 years before a hypothetical 2.0 release. | ||
|
|
||
| The goal of these guarantees is to provide stability to the ecosystem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is probably outdated? We currently have an LTS release that receives backports for at least one year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated!
docs/contributing/releasing.md
Outdated
| @@ -0,0 +1,58 @@ | |||
| ## Releasing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can drop this file entirely, as contributors normally wouldn't publish tokio to crates.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason to keep this file as well for contributors, I've removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update this link
Line 134 in 398eef8
| [guide]: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md |
Thanks! updated |
ADD-SP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
Closes #2707.
The
CONTRIBUTING.mddoc is a bit outdated and overwhelming. This PR aims at breaking the docs in different files, provides a quick start guide, and table of content.There might be some improvements that can be done but I think it's better to keep this PR for breaking up and removing outdated docs, and eventually open another PR for other improvements.
Solution
CONTRIBUTING.md