feat: Updated node from 20 to 22, minimized docker image size through multiple build stages and switching from Debian to Alpine#3
Open
DieEneSchrodinger wants to merge 1 commit intotomtomwillis:mainfrom
Conversation
… multiple build stages and switching from Debian to Alpine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking into this project because I found the image size quite massive, I also found out it was still using node 20.
Node 20 is going EOL in the end of April 2026, and because of that should be updated.
This pull request changes a couple things:
The changes to the Dockerfile have the following effects on build time and on disk size of the image:
The additional time required to build the images mostly comes from having to recompile the better-sqlite3 module on Node 22, which adds around 50 seconds to the build time.
The changes to the compose file were made to align it with the standards defined in the Dockerfile in terms of the user and group id. The volume was made to require less user input when setting up the container.
During my testing of the image I found that everything still works just like the original image.