Open
Conversation
📊 Performance MetricsPerformance Metrics (memory storage)
|
📊 Performance MetricsPerformance Metrics (postgres storage)
|
📊 Performance MetricsPerformance Metrics (nginx storage)
|
📊 Performance MetricsPerformance Metrics (cluster-valkey storage)
|
📊 Performance MetricsPerformance Metrics (dnsmasq storage)
|
…riginal protocol when TLS is terminated at the proxy level
…update related tests. Remove content-type query parameter handling from buildGetURL.
…e content type. Refactor object storage methods to support content type management.
…e readability and maintainability. Document functions and structures in handler, memory, and Valkey storage files.
…ithClient with a new method in ValkeyStorage. Update tests to ensure proper resource cleanup by ignoring errors on response body closure.
TrueCarry
reviewed
Mar 20, 2026
TrueCarry
requested changes
Mar 20, 2026
|
|
||
| // Store saves the object in memory with a TTL. Returns a content-addressable ID. | ||
| func (s *MemObjectStorage) Store(ctx context.Context, object []byte, contentType string, ttl int64) (string, error) { | ||
| id := hashObject(object, contentType) |
Contributor
There was a problem hiding this comment.
Is it good idea to have stalbe IDs? What if someone starts to use us to publicly host same item for a long time?
…package and integrating its functionality directly into the v3 storage layer.
…cessing, enhancing error handling for large payloads.
TrueCarry
reviewed
Mar 26, 2026
| EnableExpiredCache bool `env:"ENABLE_EXPIRED_CACHE" envDefault:"true"` | ||
|
|
||
| // Object Storage | ||
| ObjectStorageMaxTTL int64 `env:"OBJECT_STORAGE_MAX_TTL" envDefault:"300"` |
Contributor
There was a problem hiding this comment.
We should also have ability to limit max objects total count/size in storage. Any ideas how it can be imlemented?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
https://github.com/the-ton-tech/ton-connect/blob/06ae7458709010bab35decbdfde27ac6ce5ca141/object_storage.md