Open
Conversation
yousifS
reviewed
Nov 3, 2019
| //this function, when called on a event set up by the make player function, | ||
| // will take the person and add new dogeball traits to its key and values by calling the player class and then push into the listofPlayers array | ||
| const addPlayer = person => { | ||
| let newAttributes = new Array(10); |
There was a problem hiding this comment.
Setting up an attributes array seems odd
yousifS
reviewed
Nov 3, 2019
| } | ||
| } | ||
| // teammate will take a player and assign either red team or blue team as new key and values. | ||
| class Teammate { |
There was a problem hiding this comment.
I would have expected the Teammate class to extend the Player class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3