Skip to content

Week2 2#4

Open
tonezone108 wants to merge 3 commits intogh-pagesfrom
week2-2
Open

Week2 2#4
tonezone108 wants to merge 3 commits intogh-pagesfrom
week2-2

Conversation

@tonezone108
Copy link
Owner

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

board[1][1] == playerTurn &&
board[0][2] == playerTurn)
) {
printBoard();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure there is a reason to print the board here.

board[2][1] !== " " &&
board[2][2] !== " "
) {
printBoard();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure there is a reason to print the board here.

board[2][2] = " ";
playerTurn = "X";
} else if (
//if there is no winner or draw it immediately goes to check weather to switch to player X or O
Copy link

@yousifS yousifS Sep 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a comment in the middle of an if condition like this is really odd.
this would be better:

      else if(playerTurn == "X"){
          // if there is no winner or draw ....
          playerTurn = "O";
        } 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants