fix: correct tcp.authentificationComplete encoding in liteclient #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In liteclient, the TCP authentication packet tcp.authentificationComplete was encoded incorrectly. The code wrote magicTcpAuthentificationComplete into a 4-byte buffer and then overwrote those same 4 bytes with magicPubKey, so the packet started with pub.ed25519 instead of tcp.authentificationComplete. As a result, the server couldn’t parse the message and TCP auth failed.
Fix
Build the payload as a proper TL sequence:
magicTcpAuthentificationComplete
magicPubKey
ed25519 public key
TL-encoded signature
After that the packet is wrapped and sent. Now TCP authentification works correctly and matches the C++ implementation.