Skip to content

Added minecraft 1.12 pre7 support#333

Merged
stefandollase merged 2 commits into
masterfrom
added-minecraft-1.12-pre7-support
Jun 2, 2017
Merged

Added minecraft 1.12 pre7 support#333
stefandollase merged 2 commits into
masterfrom
added-minecraft-1.12-pre7-support

Conversation

@stefandollase
Copy link
Copy Markdown
Contributor

As opposed to my commit message in f878966

Minecraft 1.12-pre3 seems to contain malformed class files. Not only Amidst, but also standard Java decompilers cannot read them, e.g. chv.class.

This change allows Amidst to ignore these classes as long as all required classes are found.

the new snapshots do not contain malformed class files. The malformed class files simply contain lambda expressions which we were not able to recognize (just like the decompiler that I used).

This PR also adds support to read byte code that contains lambda expressions. However, it does not allow us to search for a class file by a given lambda expression.

@stefandollase stefandollase added this to the v4.3 milestone Jun 2, 2017
@stefandollase stefandollase self-assigned this Jun 2, 2017
@stefandollase stefandollase merged commit 7cbd5b5 into master Jun 2, 2017
@stefandollase stefandollase deleted the added-minecraft-1.12-pre7-support branch June 2, 2017 16:28
@ghost
Copy link
Copy Markdown

ghost commented Jun 3, 2017

http://i.imgur.com/nHS8w5x.jpg
Both v4.3 beta versions seem to have a problem with PCMCv1.11.2
Interestingly v1.11.2 came out on 16w51 NOT 17w06
I haven't checked any other versions.

@stefandollase
Copy link
Copy Markdown
Contributor Author

Yes, you are right about this. Sadly, our recognition mechanism becomes more and more fuzzy, which was one of the reasons for #146. #331 should be a first step to adjust this mechanism, however it is not yet done.

See here for which versions are currently grouped together by the recognition mechanism (scroll to the right). The marked line is the version you are talking about.

However, for this version, it is really only an issue because it might confuse the user. Other than that, it has no consequences. We still use the correct biome generator. The recognised version for example affects which algorithm is used for the structure generation, like temples. Thus, since we did not adjust these algorithms for newer versions of the game, it won't currently make a difference which version was recognised (see here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant