feat!: parse JSON with System.Text.Json #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardSmit
force-pushed
the
feature/system-text-json
branch
2 times, most recently
from
b6d883c to
e9b1049
Compare
GerardSmit
force-pushed
the
feature/system-text-json
branch
from
e9b1049 to
91754bd
Compare
|
Thank you kind sir 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the JSON parsing to System.Text.Json instead of Newtonsoft.Json.
Also changed that the HttpClient is being managed by IHttpClientFactory (when used in DI).
Currently we're creating a HttpClient every request. While the following post is from 2016 and maybe improved in .NET, it's still bad practice: https://www.aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/
A singleton HttpClient is better but will fail if
proxycheck.iochanges their DNS.Also, I enabled nullable so I'm sure that I didn't miss any null checks, and trimming for AOT cuz why not.
The project has now 0 warnings. 🔥