Fix for storing country at registration #24
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ...createUserDto.param, | ||
| handle: 'countryuser', | ||
| email: 'countryuser@example.com', | ||
| country: { code: 'US', isoAlpha3Code: 'USA' }, |
There was a problem hiding this comment.
[correctness]
The country object in the dto includes both code and isoAlpha3Code. Ensure that the isoAlpha3Code is always provided and validated, as missing or incorrect values could lead to incorrect data being stored.
| expect(mockMemberPrisma.member.create).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| data: expect.objectContaining({ | ||
| homeCountryCode: 'USA', |
There was a problem hiding this comment.
[maintainability]
Consider adding validation to ensure that homeCountryCode and competitionCountryCode are correctly set to valid ISO Alpha-3 codes. This will prevent potential data integrity issues.
| // Create the member record outside of the interactive transaction | ||
| // to avoid cross-client work while a Prisma transaction is open | ||
| try { | ||
| const isoAlpha3Code = CommonUtils.validateString( |
There was a problem hiding this comment.
[correctness]
The validateString method is used to check if userParams.country?.isoAlpha3Code is valid. Ensure that validateString correctly handles all edge cases, such as empty strings or unexpected input types, to prevent potential issues with setting homeCountryCode and competitionCountryCode to null inadvertently.
No description provided.