Feat/containerized dev stack#201
Open
JoelLarson wants to merge 2 commits into
Open
Conversation
Add Postgres and Redis/Valkey services to docker compose, wire Rails cable config to REDIS_URL, and make make up start the whole app stack in containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the dev startup flow so local runs no longer try to manage Valkey manually, and containerized runs remain explicitly supported via CONTAINERIZED=1.
What changed
Why
The old setup assumed systemctl was available and able to start Valkey, which does not work on macOS and is not the right responsibility for the app startup path. This change makes local dev behavior explicit and cross-platform, while keeping the containerized override intact.
Verification