-
Notifications
You must be signed in to change notification settings - Fork 1
Support for Bitbucket #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mschlicht-tt
commented
Jan 23, 2026
- Rework of host configuration to improve workflow, support different token types, and add better validation feedback
- Better error messages for all SCM adapters
- minor improvements for UI (e.g. place holder panel on options page if no host configured)
- Rework of host configuration to improve workflow, support different token types, and add better validation feedback - Better error messages for all SCM adapters - minor improvements for UI (e.g. place holder panel on options page if no host configured)
Closed
tt-tiwe
reviewed
Feb 5, 2026
src/scm/bitbucket.ts
Outdated
| if (this.usesBearerAuth()) { | ||
| return { Authorization: `Bearer ${token}` }; | ||
| } | ||
| return { Authorization: `Basic ${btoa(token)}` }; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My IDE is telling me that btoa is deprecated. Maybe there is an alternative to use here.
- better text in DeveloperGuide.md - Use normalizeHost where possible - replace btoa (actually only deprecated for node) - comment about bitbucket URLs in serverWorker.findScmHostForUrl
…tests for better line coverage
- focus host URL on dialog open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.