Add Copilot code-review agent skill - #67
Conversation
Track .github/skills/code-review so Copilot code review can load Trackdub REVIEW.md guidance, and keep other local skill overlays ignored. Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThis change adds a Trackdub public-core code-review skill. It defines review scope, checks, stop conditions, testing guidance, comment standards, and merge criteria. Git ignore rules now include the ChangesCode-review skill setup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds the public-core Copilot code-review skill requested by automatically discovered ticket TS-161 and makes that skill trackable while continuing to ignore local skill overlays.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| .github/skills/code-review/SKILL.md | Adds the requested Trackdub-specific Copilot review skill with valid frontmatter and references to the repository’s existing review guidance. |
| .gitignore | Narrows the skills ignore rule so the new code-review skill is committed while other local skill overlays remain ignored. |
Reviews (3): Last reviewed commit: "Address Codex and Copilot review feedbac..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Copilot code-review Agent Skill for the Trackdub public core and updates ignore rules so it’s committed/tracked while keeping other local skill overlays ignored.
Changes:
- Update
.gitignoreto ignore.github/skills/*while explicitly un-ignoring.github/skills/code-review/**. - Add
.github/skills/code-review/SKILL.mddefining Copilot code-review guidance and pointers toREVIEW.md,AGENTS.md, and the PR template.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitignore |
Adjusts ignore patterns to allow committing the code-review skill while keeping other skill overlays ignored. |
.github/skills/code-review/SKILL.md |
Introduces the Copilot code-review agent skill content for Trackdub public-core review guidance. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b8523baca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/skills/code-review/SKILL.md (1)
27-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDefine a fallback when MCP tools are unavailable.
If the GitHub Copilot review environment does not expose the configured GitHub/Linear MCP tools, this mandatory step blocks
TS-*reviews. Confirm tool availability. Otherwise, instruct reviewers to record missing issue context and continue using the supplied PR evidence.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/skills/code-review/SKILL.md around lines 27 - 28, Update the TS-* issue review guidance to first confirm whether the configured GitHub/Linear MCP tools are available. If unavailable, instruct reviewers to record that issue context could not be loaded and continue evaluating scope and completeness using the supplied PR evidence.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/skills/code-review/SKILL.md:
- Around line 27-28: Update the TS-* issue review guidance to first confirm
whether the configured GitHub/Linear MCP tools are available. If unavailable,
instruct reviewers to record that issue context could not be loaded and continue
evaluating scope and completeness using the supplied PR evidence.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 26b29379-f9b5-4ad7-8d29-48dea9a6037c
📒 Files selected for processing (2)
.github/skills/code-review/SKILL.md.gitignore
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 5/5
- In
.github/skills/code-review/SKILL.md, the instruction to updateTHIRD_PARTY_NOTICES.mdpoints to a non-existent root file, so automated reviewers may skip or misplace required notice updates and leave legal docs stale — update the guidance todocs/legal/THIRD_PARTY_NOTICES.md(or add a redirect note) to de-risk agent behavior.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/skills/code-review/SKILL.md">
<violation number="1" location=".github/skills/code-review/SKILL.md:79">
P3: This skill directs an automated reviewer to "Update THIRD_PARTY_NOTICES.md", but no such file exists at the repo root — the actual file is `docs/legal/THIRD_PARTY_NOTICES.md`. An agent following the instruction literally would look in the wrong place. Consider naming the full path to make the guidance actionable.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous Review Summaries (2 snapshots, latest commit 44bfb3c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 44bfb3c)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous review (commit 0b8523b)Status: No New Issues Found | Recommendation: Existing comments should be addressed Overview
Files Reviewed (2 files)
Reviewed by step-3.7-flash · Input: 26.3K · Output: 3.1K · Cached: 149K Review guidance: REVIEW.md from base branch |
Point reviewers at docs/legal/THIRD_PARTY_NOTICES.md so attribution checks match the repo layout. Co-authored-by: Cursor <cursoragent@cursor.com>
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds only a Markdown Copilot code-review skill and a matching .gitignore exception; no code, build, dependency, or runtime behavior changes appear in the diff. This is a docs/tooling-only change with no product, security, or operational tradeoff needing human review.
Re-trigger cubic
Approval not submitted
This repository is configured to approve as @tonythethompson, but that approval identity is unavailable.
GitHub does not allow a pull request author approval to count for their own PR.
cubic left this as a normal review comment instead of falling back to a Cubic App approval.
Preserve planner/router alias soft-hint exception from REVIEW.md, and add a fallback when Linear MCP is unavailable for TS-* context. Co-authored-by: Cursor <cursoragent@cursor.com>
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds only a Copilot code-review skill Markdown file and a scoped .gitignore exception for it. No product code, runtime behavior, schema, or policy changes, so no human-owned tradeoff remains.
Re-trigger cubic
Approval not submitted
This repository is configured to approve as @tonythethompson, but that approval identity is unavailable.
GitHub does not allow a pull request author approval to count for their own PR.
cubic left this as a normal review comment instead of falling back to a Cubic App approval.
Summary
.github/skills/code-review/SKILL.mdso GitHub Copilot code review loads Trackdub public-core review guidance (directory namecode-reviewper GitHub docs)..github/skills/code-review/**in.gitignorewhile keeping other local skill overlays ignored.REVIEW.md, dependency-direction / readiness / model-license stops, and honest test evidence.Fixes TS-161
Linked issue
Scope
Testing
dotnet build Trackdub.slnx -m:1dotnet test Trackdub.slnx -m:1Test notes
Docs-only / agent-skill addition. No code or build surface changed. Verified file tracks after
.gitignoreexception and is present on the PR head branch.Architecture review
Trackdub.AppLicense/model impact
Risk and rollback
Milestone notes
Platform & Tooling: Copilot code review skills for public core.
Agent notes
Paired PR in
trackdubllc/Trackdub-gatedadds the gated desktop skill.Made with Cursor
Note
Add Copilot code-review agent skill for Trackdub public core
Adds SKILL.md, a Markdown specification that instructs the Copilot code-review agent on review priorities, automatic stop conditions, checklist areas (architecture, pipeline/readiness, models/licensing, tests), comment style, and merge criteria. Updates .gitignore to stop ignoring the new
code-review/directory while continuing to ignore other skill directories.Macroscope summarized 4db108a.
Summary by CodeRabbit
Documentation
Chores