Skip to content

fix(errors): switches to a whitelist for errors#2307

Closed
seferturan wants to merge 1 commit into
mainfrom
fix/error_whitelist
Closed

fix(errors): switches to a whitelist for errors#2307
seferturan wants to merge 1 commit into
mainfrom
fix/error_whitelist

Conversation

@seferturan
Copy link
Copy Markdown
Contributor

🎶 Notes 🎶

  • Fixes "Something went wrong" still appears in Firefox #2250
  • Switches to using a whitelist for filtering out external noise. Checking for protocols like resource:// was not usable in all browsers. E.g. Firefox strips them out from error.stack to counter fingerprinting.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the error reporting mechanism to more reliably filter out noise from external scripts. By shifting from a protocol-based blacklist to a path-based whitelist, the application can now consistently identify relevant errors across different browsers, including those that obfuscate extension-related stack information.

Highlights

  • Error Filtering Strategy: Replaced the blacklist-based approach for filtering external error noise with a whitelist approach using bundle paths.
  • Improved Reliability: Switched from checking browser-specific extension protocols (which are often stripped for privacy) to verifying stack traces against known bundle paths, ensuring better cross-browser compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) May 11, 2026 12:42
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 11, 2026

DeepSource Code Review

We reviewed changes in 526061b...6c257ed on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript May 11, 2026 12:53p.m. Review ↗
Code coverage May 11, 2026 12:53p.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
71.6%
Javascript
71.6%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the error filtering logic in ErrorProvider.svelte to use a whitelist approach, only processing errors originating from specific SvelteKit bundle paths defined in BUNDLE_PATHS. The previous logic that filtered out browser extension protocols has been removed. Feedback was provided to optimize the stack trace access by extracting it to a variable, which reduces redundant optional chaining and improves code clarity.

Comment thread projects/client/src/lib/features/errors/ErrorProvider.svelte
@seferturan seferturan force-pushed the fix/error_whitelist branch from d5f7570 to 6c257ed Compare May 11, 2026 12:53
@seferturan seferturan requested a review from vladjerca May 11, 2026 13:07
@seferturan seferturan marked this pull request as draft May 13, 2026 15:08
auto-merge was automatically disabled May 13, 2026 15:08

Pull request was converted to draft

@seferturan
Copy link
Copy Markdown
Contributor Author

Drafted pending double check with known broken extensions in other browsers.

@vladjerca vladjerca closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Something went wrong" still appears in Firefox

2 participants