fix(errors): switches to a whitelist for errors#2307
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the error reporting mechanism to more reliably filter out noise from external scripts. By shifting from a protocol-based blacklist to a path-based whitelist, the application can now consistently identify relevant errors across different browsers, including those that obfuscate extension-related stack information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | May 11, 2026 12:53p.m. | Review ↗ | |
| Code coverage | May 11, 2026 12:53p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 71.6% |
| Javascript | 71.6% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Code Review
This pull request refactors the error filtering logic in ErrorProvider.svelte to use a whitelist approach, only processing errors originating from specific SvelteKit bundle paths defined in BUNDLE_PATHS. The previous logic that filtered out browser extension protocols has been removed. Feedback was provided to optimize the stack trace access by extracting it to a variable, which reduces redundant optional chaining and improves code clarity.
d5f7570 to
6c257ed
Compare
Pull request was converted to draft
|
Drafted pending double check with known broken extensions in other browsers. |
🎶 Notes 🎶
resource://was not usable in all browsers. E.g. Firefox strips them out from error.stack to counter fingerprinting.