Skip to content

feat: enhance footer layout and links#2326

Merged
trakt-bot[bot] merged 1 commit into
mainfrom
feature/footer-enhancements
May 18, 2026
Merged

feat: enhance footer layout and links#2326
trakt-bot[bot] merged 1 commit into
mainfrom
feature/footer-enhancements

Conversation

@ElMagnea
Copy link
Copy Markdown
Collaborator

Updates footer content with improved layout, links, and logo positioning. Removes newsletter signup experiment.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) May 14, 2026 09:39
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 14, 2026

DeepSource Code Review

We reviewed changes in e056374...35d5c84 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript May 18, 2026 2:03p.m. Review ↗
Code coverage May 18, 2026 2:03p.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
71.6%
Javascript
71.6%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the application's footer and streaming service list components. By restructuring the footer layout and grouping links, the interface becomes more intuitive and visually consistent. Additionally, the inclusion of a dedicated empty state for the 'Where to Watch' section ensures that users receive clear feedback when content is unavailable, enhancing the overall polish of the user experience.

Highlights

  • Footer Redesign: Refactored the footer layout, updated logo dimensions, and organized navigation links into logical categories (Platform, Community, Legal).
  • UI/UX Enhancements: Introduced a new 'WhereToWatchEmptyItem' component to provide a better user experience when no streaming services are available.
  • Content Updates: Renamed the 'Upcoming Schedule' label to 'Calendar' in the internationalization configuration.
Ignored Files
  • Ignored by pattern: projects/client/i18n/messages/** (1)
    • projects/client/i18n/messages/en-au.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a layout overhaul of the site footer and enhances the "Where to Watch" list's empty state. Key updates include a grid-based refactor of the footer components, semantic grouping of page links into Platform, Community, and Legal sections, and the introduction of a dedicated WhereToWatchEmptyItem component. Reviewer feedback identifies several hardcoded UI strings that should be moved to internationalization files and notes violations of the style guide regarding the unnecessary use of the lang="scss" attribute in Svelte components where standard CSS suffices.

Comment thread projects/client/src/lib/sections/footer/components/FooterLogo.svelte Outdated
Comment thread projects/client/src/lib/sections/footer/components/FooterLogo.svelte Outdated
Comment thread projects/client/src/lib/sections/footer/components/CopyRight.svelte
Comment thread projects/client/src/lib/sections/footer/components/PageLinks.svelte Outdated
Comment thread projects/client/src/lib/sections/footer/components/PageLinks.svelte Outdated
Comment thread projects/client/src/lib/sections/footer/components/PageLinks.svelte Outdated
Comment thread projects/client/src/lib/sections/lists/where-to-watch/WhereToWatchList.svelte Outdated
@seferturan seferturan force-pushed the feature/footer-enhancements branch 5 times, most recently from 1eb78f0 to 2299efe Compare May 18, 2026 13:41
@seferturan seferturan force-pushed the feature/footer-enhancements branch from 2299efe to 35d5c84 Compare May 18, 2026 14:03
@seferturan
Copy link
Copy Markdown
Contributor

Examples:
Screenshot 2026-05-18 at 15 38 12

Screenshot 2026-05-18 at 16 06 44

@seferturan seferturan self-requested a review May 18, 2026 14:07
@trakt-bot trakt-bot Bot merged commit 9d0178c into main May 18, 2026
17 of 18 checks passed
@trakt-bot trakt-bot Bot deleted the feature/footer-enhancements branch May 18, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants