Skip to content

feat: update weekly pulse stats graphs and streak UI#2329

Closed
ElMagnea wants to merge 3 commits into
mainfrom
feature/stats-weekly-pulse
Closed

feat: update weekly pulse stats graphs and streak UI#2329
ElMagnea wants to merge 3 commits into
mainfrom
feature/stats-weekly-pulse

Conversation

@ElMagnea
Copy link
Copy Markdown
Collaborator

Improves weekly pulse statistics with enhanced graphs and streak accumulator UI.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant visual and functional enhancements to the weekly statistics and streak tracking components. By modernizing the UI elements and improving the data representation for streaks and pulse graphs, the changes provide a more intuitive and polished experience for users tracking their viewing habits.

Highlights

  • Weekly Pulse Statistics UI: Refactored the Weekly Pulse statistics display to feature a cleaner, more prominent layout with updated styling for labels, values, and daily bar graphs.
  • Streak Accumulator Overhaul: Replaced the previous heatmap-style streak visualization with a new accumulator component that categorizes progress into months, weeks, and days for better readability.
  • Where to Watch Improvements: Added a new empty state component for the 'Where to Watch' section and updated the drilldown logic to improve user navigation.
Ignored Files
  • Ignored by pattern: projects/client/i18n/messages/** (1)
    • projects/client/i18n/messages/en-au.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) May 14, 2026 09:39
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 14, 2026

DeepSource Code Review

We reviewed changes in 556eef9...a6edca3 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript May 14, 2026 9:39a.m. Review ↗
Code coverage May 14, 2026 9:39a.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
71.5%
Javascript
71.5%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements UI enhancements and refactors across several components, notably introducing a new WhereToWatchEmptyItem component for empty states and refactoring the StreakAccumulator to use Svelte snippets for grouped time intervals. Significant styling updates were applied to the "Pulse" statistics components, including a darker theme and improved visualization for daily bars. Feedback highlights the need to internationalize hardcoded strings in the new empty state component, remove a redundant lang="scss" attribute where standard CSS suffices, and refactor duplicated styles between the "Where to Watch" list and drawer components.

Comment on lines +1 to +11
<script lang="ts"></script>

<div class="where-to-watch-item">
<div class="where-to-watch-item-content" data-variant="service">
<span class="sad-face" aria-hidden="true">😢</span>
<p class="empty-text">
<span>No Services</span>
<span>Available</span>
</p>
</div>
</div>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoded user-facing strings should be internationalized. Use the existing messages from $lib/features/i18n/messages.ts to ensure consistency and support for multiple languages.

</div>
{/if}

<style lang="scss">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lang="scss" attribute is redundant here as no SCSS-specific features are being used. Modern CSS supports nesting natively, and Svelte handles :global() in plain CSS blocks.

Comment on lines +158 to +180
.where-to-watch-empty {
display: flex;
justify-content: flex-start;
align-items: flex-start;
align-self: flex-start;
width: fit-content;
margin-inline: 0;
padding-inline: 0;
padding-block: var(--ni-12);
min-height: var(--height-where-to-watch-list);
}

:global(.section-list-empty-state) {
width: auto;
margin: 0;
padding-inline: 0;
align-items: flex-start;
justify-content: flex-start;
}

:global(.section-list-empty-state:not(:has(:global(.trakt-skeleton-list)))) {
width: auto;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These styles are identical to the ones added in WhereToWatchList.svelte. Consider refactoring this shared logic into a common utility class or shared stylesheet to avoid duplication and improve maintainability.

@seferturan
Copy link
Copy Markdown
Contributor

Will be tackled differently (e.g. when we add the screen time version).

@seferturan seferturan closed this May 19, 2026
auto-merge was automatically disabled May 19, 2026 15:21

Pull request was closed

@seferturan seferturan deleted the feature/stats-weekly-pulse branch May 19, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants