Skip to content

feat: improve list filter and dropdown navigation#2330

Closed
ElMagnea wants to merge 4 commits into
mainfrom
feature/list-filter-dropdowns
Closed

feat: improve list filter and dropdown navigation#2330
ElMagnea wants to merge 4 commits into
mainfrom
feature/list-filter-dropdowns

Conversation

@ElMagnea
Copy link
Copy Markdown
Collaborator

Enhances list filtering and dropdown navigation components.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) May 14, 2026 09:39
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user interface and navigation components across the application. Key changes include standardizing dropdown interactions by migrating to a unified Select component, improving the visual presentation of statistical data, and adding helpful empty states for 'Where to Watch' sections. Additionally, it introduces minor functional improvements to list management and user interaction components.

Highlights

  • UI/UX Standardization: Standardized dropdown and filter interactions across the application by migrating various custom implementations to a unified Select component.
  • Component Enhancements: Added a collapsed state to SectionList and integrated the AddReviewAction into RecentlyWatchedItem for improved functionality.
  • Stats Visualization Overhaul: Refactored the StreakAccumulator and updated WeeklyPulse graphs to provide better readability and visual consistency.
  • Empty State Improvements: Introduced the WhereToWatchEmptyItem component to provide clearer feedback when no streaming services are available.
Ignored Files
  • Ignored by pattern: projects/client/i18n/messages/** (1)
    • projects/client/i18n/messages/en-au.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 14, 2026

DeepSource Code Review

We reviewed changes in 556eef9...4cf57ed on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript May 14, 2026 9:39a.m. Review ↗
Code coverage May 14, 2026 9:39a.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
71.5%
Javascript
71.5%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates UI components by standardizing dropdowns with a Select component, refactoring stats visualizations, and adding review actions to history items. It also introduces a new empty state for the 'Where to Watch' section. Review feedback focuses on replacing hardcoded color values with CSS custom properties to adhere to the project's theming standards.

height: var(--ni-16);
color: var(--color-text-emphasis);
}
background: #1d1f21; // Dark background matching the photo
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoded color value detected. Please use a CSS custom property for theming to ensure consistency.

    background: var(--color-card-background);
References
  1. Use CSS custom properties for theming. (link)

overflow: hidden;
height: 100%;
box-sizing: border-box;
background: #1d1f21;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoded color value detected. Please use a CSS custom property for theming to ensure consistency.

    background: var(--color-card-background);
References
  1. Use CSS custom properties for theming. (link)

flex: 1;
display: flex;
justify-content: center;
background: rgba(255, 255, 255, 0.05);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoded color value detected. Please use a CSS custom property for theming to ensure consistency.

    background: var(--color-background-transparent);
References
  1. Use CSS custom properties for theming. (link)

border-radius: var(--ni-2);
left: 0;
right: 0;
background: #333; // Default grey for bars
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoded color value detected. Please use a CSS custom property for theming to ensure consistency.

    background: var(--color-grey);
References
  1. Use CSS custom properties for theming. (link)

@seferturan
Copy link
Copy Markdown
Contributor

Closing this. Will be tackled differently. Also this was missing the select component 😅

@seferturan seferturan closed this May 20, 2026
auto-merge was automatically disabled May 20, 2026 12:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants