Skip to content

iOS i18n updates#2344

Merged
trakt-bot[bot] merged 1 commit into
mainfrom
ios/i18n-updates
May 18, 2026
Merged

iOS i18n updates#2344
trakt-bot[bot] merged 1 commit into
mainfrom
ios/i18n-updates

Conversation

@tysonkerridge
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the internationalization metadata configuration to enable specific features for the iOS platform. By removing 'ios' from the exclusion lists of several UI strings, these elements will now be correctly localized and displayed within the iOS client.

Highlights

  • iOS Localization Enablement: Removed 'ios' from the 'exclude' lists across multiple internationalization keys in the metadata configuration.
  • Feature Availability: Updated various UI components, including notes management and profile links, to be available on the iOS platform.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 15, 2026

DeepSource Code Review

We reviewed changes in 3b255ad...0500579 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript May 18, 2026 10:45a.m. Review ↗
Code coverage May 18, 2026 10:45a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables several UI strings for the iOS platform by removing "ios" from their exclusion lists in the English localization metadata. The changes cover features such as review replies, user profiles, activity lists, cover image management, personal notes, and translation settings. Feedback focuses on ensuring feature parity by enabling additional related strings for each of these features to prevent an incomplete or inconsistent user interface on iOS.

Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
@tysonkerridge tysonkerridge marked this pull request as draft May 15, 2026 08:12
@tysonkerridge
Copy link
Copy Markdown
Collaborator Author

I’ll review the above feedback on Monday and request review again afterwards

@tysonkerridge
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables a wide range of translation keys for the iOS platform by removing them from the exclusion list in en.json. The changes cover various UI components such as review dialogs, list management, activity sections, and user notes. Feedback from the review highlights several inconsistencies where related keys—such as aria-labels, complementary action buttons, and descriptive text—remain excluded. To ensure a complete and consistent user experience on iOS, these associated keys should also be enabled.

Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
Comment thread projects/client/i18n/meta/en.json
@tysonkerridge tysonkerridge marked this pull request as ready for review May 18, 2026 04:42
@trakt-bot trakt-bot Bot enabled auto-merge (rebase) May 18, 2026 04:42
@tysonkerridge tysonkerridge requested review from seferturan and vladjerca and removed request for seferturan and vladjerca May 18, 2026 04:45
@trakt-bot trakt-bot Bot merged commit 883c7c6 into main May 18, 2026
12 of 14 checks passed
@trakt-bot trakt-bot Bot deleted the ios/i18n-updates branch May 18, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants