iOS i18n updates#2344
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the internationalization metadata configuration to enable specific features for the iOS platform. By removing 'ios' from the exclusion lists of several UI strings, these elements will now be correctly localized and displayed within the iOS client. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | May 18, 2026 10:45a.m. | Review ↗ | |
| Code coverage | May 18, 2026 10:45a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Code Review
This pull request enables several UI strings for the iOS platform by removing "ios" from their exclusion lists in the English localization metadata. The changes cover features such as review replies, user profiles, activity lists, cover image management, personal notes, and translation settings. Feedback focuses on ensuring feature parity by enabling additional related strings for each of these features to prevent an incomplete or inconsistent user interface on iOS.
|
I’ll review the above feedback on Monday and request review again afterwards |
9b6f8b7 to
081e203
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enables a wide range of translation keys for the iOS platform by removing them from the exclusion list in en.json. The changes cover various UI components such as review dialogs, list management, activity sections, and user notes. Feedback from the review highlights several inconsistencies where related keys—such as aria-labels, complementary action buttons, and descriptive text—remain excluded. To ensure a complete and consistent user experience on iOS, these associated keys should also be enabled.
081e203 to
94f16cb
Compare
94f16cb to
0500579
Compare
No description provided.